Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run jib-gradle as root #214

Merged
merged 1 commit into from
Mar 9, 2020
Merged

Conversation

piyush-garg
Copy link
Contributor

This will fix the issue of task not
working on OpenShift as it needs root access and
by default on OpenShift pod run as nonroot

Fix #198

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

This will fix the issue of task not
working on OpenShift as it needs root access and
by default on OpenShift pod run as nonroot

Fix tektoncd#198
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 6, 2020
@chanseokoh
Copy link
Contributor

If you are fine with this config, I'm good for the time being. I think I'll approve this today.

BTW, when we get rid of /home/tekton in the future, we will have to revisit this and see if there's a better approach. I may need your help then.

@piyush-garg
Copy link
Contributor Author

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2020
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2020
@piyush-garg
Copy link
Contributor Author

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2020
@piyush-garg
Copy link
Contributor Author

@vdemeester This fix is working for us on OpenShift Ci, we just need to add jib-gradle to run with serviceAccount. See if it looks good.

@chanseokoh Sure, we can visit this again when we have a proper fix for this in tektoncd/pipeline as you are working already. Feel free to ping me,

Copy link
Member

@hrishin hrishin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2020
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chanseokoh, hrishin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 46bdfaf into tektoncd:master Mar 9, 2020
piyush-garg added a commit to piyush-garg/catalog that referenced this pull request Mar 9, 2020
This will add jib-gradle to priviledged as this task
needs to be run as non-root

Fix upstream tektoncd#214
added to run as root
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jib-gradle not working on OpenShift
4 participants