-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run jib-gradle as root #214
Conversation
This will fix the issue of task not working on OpenShift as it needs root access and by default on OpenShift pod run as nonroot Fix tektoncd#198
If you are fine with this config, I'm good for the time being. I think I'll approve this today. BTW, when we get rid of |
/hold |
/hold cancel |
@vdemeester This fix is working for us on OpenShift Ci, we just need to add jib-gradle to run with serviceAccount. See if it looks good. @chanseokoh Sure, we can visit this again when we have a proper fix for this in tektoncd/pipeline as you are working already. Feel free to ping me, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chanseokoh, hrishin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This will add jib-gradle to priviledged as this task needs to be run as non-root Fix upstream tektoncd#214 added to run as root
This will fix the issue of task not
working on OpenShift as it needs root access and
by default on OpenShift pod run as nonroot
Fix #198
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.